desktop: get anchor scroll lock working #4345
Merged
+159
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patosullivan
requested review from
dnbrwstr,
davidisaaclee,
arthyn and
latter-bolden
patosullivan
changed the title
davidisaaclee
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Code generally looks good + appreciate the cleanup – putting some notes down since I need to log off for the night:
- Outside of this PR's scope, it looks like anchors are kind of broken now, I think due to unconfirmed posts (i.e. loading the most recent messages asap) – you can see this by doing a search in channel and jumping to a result :( commenting out this
useEffectdisables loading unconfirmeds and restores the anchor behavior (which lgtm with this PR's changes) - During a
onScrollToIndexFailed,developscrolls to an estimated offset, then attempts to do anotherscrollToIndex. I can't get aonScrollToIndexFailedto trigger, but I remember that whenonScrollToIndexFailedhappened, the estimated offset was often wrong, leaving you at an irrelevant part of the scroll. I'm trying to get this to trigger; but if I can't hit it, I'm happy to see it simplified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes tlon-3470
This splits useAnchorScrollLock out to its own file and simplifies the logic and state management quite a bit. There is now just a single place where
scrollToIndexgets called. I think it was failing on web because of a race condition.Probably best for @davidisaaclee to take a look at this one, but open to reviews from anyone else too.