logs: improve Lure tracing #4342
Merged
+77
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latter-bolden
requested changes
Jan 16, 2025
latter-bolden
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Let's double check that PostHog token, but otherwise looking good!
Sorry to expand scope, but could we add one last bit:
- From
%reellog an Invite Link Created event when it receives%reel-confirmationfrom the Provider (include token and flag) - From
%reellog an Invite Link Removed event when it receives%reel-undescribe(include token and flag)
|
Re Posthog token. If it the key is on the ship, the user can just read it, no matter where we put it. If want to do anything about it we would have to setup a logging service somewhere. |
|
@arthyn @latter-bolden Just in case you missed it, there is also a sibling PR in the landscape repo: tloncorp/landscape#304 |
|
Thanks. @arthyn and @latter-bolden obviously this is of critical importance to get out to livenet early next week. Thanks for your expedient reviews. :) |
latter-bolden
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arbitrary JSON data can now be supplied with a %logs report.
Taking advantage of this, Lure tracing in %grouper is improved.