Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: move action menus to popovers #4338

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

patosullivan
Copy link
Member

Fixes tlon-3314

Moves the ChatMessageActions and ChatOptionsSheet (group and channel options) into popovers on desktop web.

Also:

  • fixes some type issues I found a long the way
  • took a weed-whacker to some of the errors we frequently see in the browser console

Looks like this:
image
image
image

I also tested on mobile, everything looks and works the same.

Copy link

linear bot commented Jan 15, 2025

@patosullivan patosullivan force-pushed the po/tlon-3314-move-action-menus-to-popovers-on-desktop branch from 6fac5a7 to 4a5070e Compare January 15, 2025 14:34
@patosullivan
Copy link
Member Author

Working on adding a popover to CreateChatSheet now as well.

@patosullivan
Copy link
Member Author

Ok, CreateChatSheet (the menu that's triggered from the "Add" button at the top of the ChatList) now has a popover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant