-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop: move action menus to popovers #4338
Open
patosullivan
wants to merge
8
commits into
develop
Choose a base branch
from
po/tlon-3314-move-action-menus-to-popovers-on-desktop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
desktop: move action menus to popovers #4338
patosullivan
wants to merge
8
commits into
develop
from
po/tlon-3314-move-action-menus-to-popovers-on-desktop
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hatInput w/clearing drafts on edit, clear out a few lingering errors we've seen in the browser console
patosullivan
force-pushed
the
po/tlon-3314-move-action-menus-to-popovers-on-desktop
branch
from
January 15, 2025 14:34
6fac5a7
to
4a5070e
Compare
Working on adding a popover to CreateChatSheet now as well. |
Ok, CreateChatSheet (the menu that's triggered from the "Add" button at the top of the ChatList) now has a popover. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tlon-3314
Moves the ChatMessageActions and ChatOptionsSheet (group and channel options) into popovers on desktop web.
Also:
Looks like this:
I also tested on mobile, everything looks and works the same.