Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup + standardize text inputs #4317

Merged
merged 3 commits into from
Jan 14, 2025
Merged

cleanup + standardize text inputs #4317

merged 3 commits into from
Jan 14, 2025

Conversation

dnbrwstr
Copy link
Contributor

@dnbrwstr dnbrwstr commented Jan 8, 2025

This PR condenses our various TextInputs into a single input and tweaks some styling to better match design.

@jamesacklin
Copy link
Member

Single-line inputs all look good!

Unfortunately multi-line "textarea" inputs are broken on web:

Screen.Recording.2025-01-08.at.9.58.18.AM.mov
Screen.Recording.2025-01-08.at.9.58.37.AM.mov

Confirmed they're also broken in the iOS simulator:

Screenshot 2025-01-08 at 10 46 23 AM

Normally there's text in there, it seems like they focus but I can't see anything I'm typing.

@dnbrwstr
Copy link
Contributor Author

dnbrwstr commented Jan 8, 2025

Oof, good catch, looking!

@dnbrwstr dnbrwstr force-pushed the db/text-input-cleanup branch from 5fcb2c4 to 6e001d7 Compare January 14, 2025 20:35
@dnbrwstr
Copy link
Contributor Author

Should be fixed if you wanna take another look @jamesacklin .

Copy link
Member

@jamesacklin jamesacklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good to me! Thanks.

@dnbrwstr dnbrwstr merged commit e6a5387 into develop Jan 14, 2025
1 check passed
@dnbrwstr dnbrwstr deleted the db/text-input-cleanup branch January 14, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants