Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: implement notebook refs #3720

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

patosullivan
Copy link
Member

Fixes TLON-2255

Looks like this:
Simulator Screenshot - iPhone 15 Pro - 2024-07-08 at 15 54 37
Simulator Screenshot - iPhone 15 Pro - 2024-07-08 at 15 54 45
Simulator Screenshot - iPhone 15 Pro - 2024-07-08 at 15 54 48

Will cause some merge conflicts with my other PR, but nbd.

Copy link

linear bot commented Jul 8, 2024

Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great!

Copy link
Member

@jamesacklin jamesacklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Eventually I think we'll want to start stripping out the channel names themselves in favor of things like "SingleInline" or "SingleBlock." That's a discussion for another day, thanks for getting this in.

@patosullivan patosullivan merged commit 1109b76 into develop Jul 9, 2024
1 check passed
@patosullivan patosullivan deleted the po/tlon-2255-implement-notebook-refs branch July 9, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants