Skip to content

Commit

Permalink
Python GIL release for PointCloud::OrientNormals*
Browse files Browse the repository at this point in the history
  • Loading branch information
tlangmo committed Feb 1, 2024
1 parent 88e2a79 commit f735b5a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2024-02-01
### Added
- Python GIL release for `PointCloud::OrientNormals*`

## 2024-02-01
### Added
- Python GIL release for `PointCloud::EstimateNormals` and `PointCloud::VoxelDownSample`
Expand Down
3 changes: 3 additions & 0 deletions cpp/pybind/geometry/pointcloud.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,17 @@ void pybind_pointcloud(py::module &m) {
"fast_normal_computation"_a = true)
.def("orient_normals_to_align_with_direction",
&PointCloud::OrientNormalsToAlignWithDirection,
py::call_guard<py::gil_scoped_release>(),
"Function to orient the normals of a point cloud",
"orientation_reference"_a = Eigen::Vector3d(0.0, 0.0, 1.0))
.def("orient_normals_towards_camera_location",
&PointCloud::OrientNormalsTowardsCameraLocation,
py::call_guard<py::gil_scoped_release>(),
"Function to orient the normals of a point cloud",
"camera_location"_a = Eigen::Vector3d(0.0, 0.0, 0.0))
.def("orient_normals_consistent_tangent_plane",
&PointCloud::OrientNormalsConsistentTangentPlane,
py::call_guard<py::gil_scoped_release>(),
"Function to orient the normals with respect to consistent "
"tangent planes",
"k"_a)
Expand Down

0 comments on commit f735b5a

Please sign in to comment.