Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a template approach to specify imaging and self-calibration settings #80

Merged
merged 12 commits into from
Apr 11, 2024

Conversation

tjgalvin
Copy link
Owner

To-date imaging (e.g. wsclean), self-calibration (e.g. gaincal) and other things have been hard-coded into the flint codebase. When updating these throughout the rounds of self-calibration a dictionary with updated values would be obtained and splatted into the creation of the appropriate Options.

This is pretty tiresome. If the git history is examined it would be pretty obvious how many times commits were made purely to change the image size, solution interval, or something trivial.

This pull request introduces a template yaml file that is used to set the options that may or may not evolve as the pipeline runs. The idea is that a file (at the moment a yaml file) is parsed into a Strategy class, which is nothing more than a glorified name for a dictionary (but nice for type checking). Throughout the pipeline the Strategy with be investigated to:

  • get defaults for an Option mode
  • check for and updated values for the specific round of imaging
  • update the defaults
  • return the updated defaults

The existing infrastructure to overload the hardcoded defaults of an Option type class is used as normal.

@tjgalvin tjgalvin requested a review from AlecThomson April 11, 2024 05:44
@tjgalvin
Copy link
Owner Author

This addresses #4

@tjgalvin tjgalvin merged commit a4b64a2 into main Apr 11, 2024
2 checks passed
@tjgalvin tjgalvin deleted the template branch May 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant