Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback for BANE singularity stream handler #204

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Conversation

tjgalvin
Copy link
Owner

@tjgalvin tjgalvin commented Jan 2, 2025

Its been noted that sometimes BANE gets into a weird deadlock type error. I suspect it is some strange conspiracy that could be eliminated with changes to BANE and its uses of shared memory and load on the system. I can not reliably reproduce it.

This pull request attempts to detect the deadlock mode, and raise an error, which is subsequently prompts flint to rerun the singularity command.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.56%. Comparing base (427088e) to head (d073286).

Files with missing lines Patch % Lines
flint/sclient.py 14.28% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files          35       35           
  Lines        6187     6203   +16     
=======================================
+ Hits         3747     3757   +10     
- Misses       2440     2446    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit 7dc57e3 into main Jan 2, 2025
2 checks passed
@tjgalvin tjgalvin deleted the banehandler branch January 2, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants