Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timelimit context handler, eye towards BANE deadlocks #200

Merged
merged 5 commits into from
Dec 27, 2024
Merged

Conversation

tjgalvin
Copy link
Owner

It has been noted that under some strange set of circumstances that BANE can get into a deadlock. There has been some issue raised here for a while (#187 ).

This is a heavy handed attempt to fix it. It establishes a timelimit on the execution of the bane and aegean tasks. Nominally this is set to 45 minutes.

Really this should be fixed where it is an actually problem. Something in BANE, sharedmemory and heavy loads is causing something to go wrong. But for the moment this will do.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.53%. Comparing base (6ee17b8) to head (0d985b0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
flint/prefect/common/imaging.py 25.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   60.48%   60.53%   +0.05%     
==========================================
  Files          35       35              
  Lines        6154     6190      +36     
==========================================
+ Hits         3722     3747      +25     
- Misses       2432     2443      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit 2fa5e87 into main Dec 27, 2024
2 checks passed
@tjgalvin tjgalvin deleted the banetime branch December 27, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants