Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weight text files after linmos in spectral line flow #197

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

tjgalvin
Copy link
Owner

The channel-wise linmos procedure creates many small text files when computing the channel weights. This PR introduces a new option to remove them when linmos has completed. This required some small changes to the helper function in the linmos call.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.48%. Comparing base (9946a0e) to head (75ec403).

Files with missing lines Patch % Lines
flint/coadd/linmos.py 51.85% 13 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   60.48%   60.48%   -0.01%     
==========================================
  Files          35       35              
  Lines        6135     6154      +19     
==========================================
+ Hits         3711     3722      +11     
- Misses       2424     2432       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit 6ee17b8 into main Dec 11, 2024
2 checks passed
@tjgalvin tjgalvin deleted the cleanlinmos branch December 11, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants