Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated fitscube to corm larger than memory cubes #196

Merged
merged 31 commits into from
Dec 10, 2024
Merged

Conversation

tjgalvin
Copy link
Owner

flint uses fitscube to form image cubes out of many single plane fits images. To date this was all done in memory and required sufficient resources. This was not really scalable to combining channel images after linmos was performed.

@AlecThomson has re-worked fitscube to use asyncio and a pre-stashed final fits cube to worker within the memory limitations. This also improves the overall performance.

There was a slight change in some of the API components along the way, but I think these are largely dealt with.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 62.96296% with 30 lines in your changes missing coverage. Please review.

Project coverage is 60.48%. Comparing base (806e944) to head (068f47b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
flint/prefect/flows/subtract_cube_pipeline.py 17.85% 23 Missing ⚠️
flint/prefect/common/imaging.py 0.00% 6 Missing ⚠️
flint/naming.py 97.61% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   60.48%   60.48%           
=======================================
  Files          35       35           
  Lines        6089     6135   +46     
=======================================
+ Hits         3683     3711   +28     
- Misses       2406     2424   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit 9946a0e into main Dec 10, 2024
2 checks passed
@tjgalvin tjgalvin deleted the fitscubenew branch December 10, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants