-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial continuum-subtraction and spectral line prefect flow #192
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 60.91% 60.48% -0.44%
==========================================
Files 34 35 +1
Lines 5852 6089 +237
==========================================
+ Hits 3565 3683 +118
- Misses 2287 2406 +119 ☔ View full report in Codecov by Sentry. |
This is an initial attempt at implementing a basic workflow to handle the processing of spectral line data.
It is a little hefty. What is in it?
wsclean
with its-save-source-list
option. This is a sky-model file of each clean component and the corresponding SED that was constrained.addmodel
program that forms part of Andre Offringa'scalibrate
program, which can predict the model visibilities of components described by the sky-model at full channel resolutiontaql
, which should scale to large MSsOf less importance are:
addmodel
prediction being carried out in a subflow with a different data runner. This is the first time such an approach has been used, so may changeflint_no_log_wsclean_output
attribute toWSCleanOptions
, which is a directive for flint more than something that influences wscleanPoints to think further about:
flint_no_log_wsclean_output
is a usage pattern that is acceptable. Would having a separateFlintOptions
to control these miscellaneous things be better?WSCleanOptions
was already being passed all the way through. Alternatives would include passing anyFlintOptions
all the way through helper functions, or perhaps using environment variables to control points like this.