Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI for flint_masking #178

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Improve CLI for flint_masking #178

merged 11 commits into from
Oct 10, 2024

Conversation

tjgalvin
Copy link
Owner

Some interest has been received around using some of the masking operations for use via a cli. Upon inspection it was pretty clear the cli was out of date and fairly primitive.

This change improves the CLI, and marks an early version of the minimum box car artifact masker as deprecated and to be removed.

A separate erosion mode based on the shape of the restoring beam has also been added.

Some other bits of dead code has been removed, and some light reordering of the internals / keyword parameters.

Tests have been added for some of the new features, and some have been modified in anticipation of removing the older minimum box car artifact masker.

@tjgalvin tjgalvin mentioned this pull request Oct 10, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.40506% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.32%. Comparing base (ddc2686) to head (a5b8161).

Files with missing lines Patch % Lines
flint/masking.py 92.40% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   59.79%   60.32%   +0.53%     
==========================================
  Files          33       33              
  Lines        5686     5727      +41     
==========================================
+ Hits         3400     3455      +55     
+ Misses       2286     2272      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit 4367b4e into main Oct 10, 2024
2 checks passed
@tjgalvin tjgalvin deleted the beamkasking branch October 10, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants