Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks to cube convolution and linmos #176

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Checks to cube convolution and linmos #176

merged 3 commits into from
Oct 7, 2024

Conversation

tjgalvin
Copy link
Owner

@tjgalvin tjgalvin commented Oct 7, 2024

In astropy==6.1.4 a change was made to how astropy.units.Units with 0 scale are handled. This caused a collection of errors and confusion.

In this change I have pinned astropy to 6.1.3 while the main up-stream module radio-beam is fixed.

Throughout this debugging process I have also broken about the cube convolution test, and am using the process executor.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.79%. Comparing base (719ec89) to head (8f493c4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   59.54%   59.79%   +0.24%     
==========================================
  Files          33       33              
  Lines        5686     5686              
==========================================
+ Hits         3386     3400      +14     
+ Misses       2300     2286      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit ddc2686 into main Oct 7, 2024
2 checks passed
@tjgalvin tjgalvin deleted the cubeconv branch October 7, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants