Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form wsclean sub-band cubes, convol and then linmos #173

Merged
merged 33 commits into from
Sep 24, 2024
Merged

Form wsclean sub-band cubes, convol and then linmos #173

merged 33 commits into from
Sep 24, 2024

Conversation

tjgalvin
Copy link
Owner

wsclean deals with the wide-bandwidth of visibility data by imaging some number of sub-channel intervals. In a previous pull request these sub-band images were all concatenated together into a single cube - which introduced a modest reduction in the number of files on disk throughout processing.

This pull request extends that to convolve them to a common resolution across each sub-band image, and then linmos the set of spectral cubes together. The convolution is performed using the racs-tools beamcon_3D script, and is currently configured to convolve each channel to the best common resolution in isolation of others.

Tests have been added along the way.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.15217% with 77 lines in your changes missing coverage. Please review.

Project coverage is 59.54%. Comparing base (d59d357) to head (7eea24d).

Files with missing lines Patch % Lines
flint/convol.py 39.62% 32 Missing ⚠️
flint/prefect/common/imaging.py 20.00% 32 Missing ⚠️
flint/prefect/flows/continuum_pipeline.py 10.00% 9 Missing ⚠️
flint/coadd/linmos.py 93.54% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   59.17%   59.54%   +0.37%     
==========================================
  Files          33       33              
  Lines        5536     5686     +150     
==========================================
+ Hits         3276     3386     +110     
- Misses       2260     2300      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit 6848f6d into main Sep 24, 2024
2 checks passed
@tjgalvin tjgalvin deleted the cube branch December 4, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants