Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate RMS of inner region during validation plot #166

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

tjgalvin
Copy link
Owner

When putting a field through the validation plot and table creating a median RMS is computed from the entire RMS computed by bane, which includes the increased in noise towards the edge field as a result of the higher attenuation of the primary beam.

This introduces a change to extract a set of pixels from the inner region of the RMS image when computing the RMSImageInfo structure to avoid this roll off.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (547015f) to head (bad33b5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   56.41%   56.54%   +0.12%     
==========================================
  Files          33       33              
  Lines        5119     5134      +15     
==========================================
+ Hits         2888     2903      +15     
  Misses       2231     2231              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit 1d855ef into main Aug 27, 2024
2 checks passed
@tjgalvin tjgalvin deleted the inneregion branch August 27, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants