Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broke apart a linmos parset creation #163

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Broke apart a linmos parset creation #163

merged 1 commit into from
Aug 16, 2024

Conversation

tjgalvin
Copy link
Owner

Separated our some of the steps that go into creating the linmos parset file. Did this as for some time had incorrectly been specifying the rotation alpha variable in the parset. Some tests added to try to help make sure this does not happen.

this one was to fix some silly pirate mistakes
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.49%. Comparing base (cdab453) to head (ace1d97).

Files Patch % Lines
flint/coadd/linmos.py 94.44% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   56.23%   56.49%   +0.26%     
==========================================
  Files          33       33              
  Lines        5104     5110       +6     
==========================================
+ Hits         2870     2887      +17     
+ Misses       2234     2223      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit ca82eb3 into main Aug 16, 2024
2 checks passed
@tjgalvin tjgalvin deleted the linmoscheck branch August 16, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants