Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the pol field name #161

Merged
merged 13 commits into from
Aug 15, 2024
Merged

Changing the pol field name #161

merged 13 commits into from
Aug 15, 2024

Conversation

tjgalvin
Copy link
Owner

The yandasoft linmos task requires that file names describe the stokes parameter of the image. It does not inspect the fits header values. Specifically the software searches for .i., .q., .u. or .v.. This is file name format is required should we want to perform a leakage correction.

Throughout it also became clear that the application of holography was not right. Part of this was an older linmos version, part of this was a bad check on a float of value 0.0...

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.13208% with 10 lines in your changes missing coverage. Please review.

Project coverage is 56.24%. Comparing base (caa4169) to head (2bfcb43).

Files Patch % Lines
flint/coadd/linmos.py 33.33% 4 Missing ⚠️
flint/leakage.py 69.23% 4 Missing ⚠️
flint/imager/wsclean.py 96.87% 1 Missing ⚠️
flint/prefect/common/imaging.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   55.90%   56.24%   +0.34%     
==========================================
  Files          33       33              
  Lines        5057     5092      +35     
==========================================
+ Hits         2827     2864      +37     
+ Misses       2230     2228       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjgalvin tjgalvin merged commit 1e62863 into main Aug 15, 2024
2 checks passed
@tjgalvin tjgalvin deleted the polname branch August 16, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants