Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and write packets with multiple questions for mDNS #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Read and write packets with multiple questions for mDNS #17

wants to merge 3 commits into from

Conversation

kmpm
Copy link

@kmpm kmpm commented Oct 6, 2014

Full roundtrip does not work because of lacking utf-8 support.

Implements first part of issue #1.
Tests and closes #14
Part 2 of issue #1.
Test packet generated by 2 chromecast devices
Still some issues when writing so roundtrip
does not work.

Conflicts:
	packet.js
@kmpm
Copy link
Author

kmpm commented Oct 6, 2014

This will close #14.
The fixture files added are examples from 2 chromecast devices and 1 netgear readynas.
So packets without question and multiple questions are definitely out in the wild.
But it's only for mDNS/zeroconf applications.

@taoeffect
Copy link
Collaborator

Interesting, thank you, will need to find time for review. @tjfontaine @silverwind or anyone else feel free to check this out if you have the time. Looks very useful! 👍

@silverwind
Copy link

Not familar with mDNS yet, but it's interesting.

@kmpm
Copy link
Author

kmpm commented Jan 1, 2015

I would like to have this included but I don't know what to do to help out.
What this does is to support what is described in http://tools.ietf.org/html/rfc1035
Look at section 4.1.1. Header section format and 4.1.2. Question section format.

QDCOUNT         an unsigned 16 bit integer specifying the number of
                entries in the question section.

The section contains QDCOUNT (usually 1) entries

This is necessary for being able to use this module for RFC 6734 "DNS-Based Service Descovery" and RFC 6762 "Multicast DNS". This doesn't require anything strange in the message format. It's using the existing DNS message structure, name syntax, and resource record types as RFC 1035.

If there are any code style issues, bad practice or anything else with the code I'll gladly fix it but I would like some feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants