Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2498: Improve Document Converter default value for <pluginname>converter-options #3489

Open
wants to merge 2 commits into
base: feature/7.5/DOC-2498
Choose a base branch
from

Conversation

kemister85
Copy link
Contributor

@kemister85 kemister85 commented Oct 24, 2024

Ticket: DOC-2498

Site: Release notes Export to PDF
Site: Release notes Export to Word
Site: Release notes Import from Word
Site: Default value change: Export to PDF
Site: Default value change: Export from Word
Site: Default value change: Import from Word

Changes:

  • Improve Document Converter default value for <pluginname>converter-options TINY-11396

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

@kemister85 kemister85 added the upcoming release Documentation for features currently under development/QA label Oct 24, 2024
@kemister85 kemister85 added this to the TinyMCE 7.5 milestone Oct 24, 2024
@kemister85 kemister85 requested review from MitchC1999 and Skylite73 and removed request for a team October 24, 2024 02:31

*Default value:* `{}`
[NOTE]
As of {productname} 7.5.0, the default value of the `exportpdf_converter_options` setting has been updated to the following:
Copy link
Contributor

@FarzadHayat FarzadHayat Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to hint at the fact that there was pretty much no previous default value (i.e. {}), for anyone who might be looking at docs and wondering what the default value was before TinyMCE 7.5.0. Would need to do the same for the other two converters.

Suggested change
As of {productname} 7.5.0, the default value of the `exportpdf_converter_options` setting has been updated to the following:
As of {productname} 7.5.0, the `exportpdf_converter_options` setting now comes with a default value set to the following:

Copy link
Contributor

@FarzadHayat FarzadHayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upcoming release Documentation for features currently under development/QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants