Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-2498: Autocompleter would not activate after applying an inline format like font size in some cases. #3483

Open
wants to merge 1 commit into
base: feature/7.5/DOC-2498
Choose a base branch
from
Open

DOC-2498: Autocompleter would not activate after applying an inline format like font size in some cases. #3483

wants to merge 1 commit into from

Conversation

kemister85
Copy link
Contributor

@kemister85 kemister85 commented Oct 22, 2024 •
edited
Loading

Ticket: DOC-2498

Site: Staging branch

Changes:

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

@kemister85 kemister85 added the upcoming release Documentation for features currently under development/QA label Oct 22, 2024
@kemister85 kemister85 added this to the TinyMCE 7.5 milestone Oct 22, 2024
@kemister85 kemister85 requested review from EkimChau and Skylite73 and removed request for a team October 22, 2024 06:10
LewisAtTiny
LewisAtTiny approved these changes Oct 23, 2024
View reviewed changes
Copy link

@LewisAtTiny LewisAtTiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Explains the issue, effect and fix at an easy to understand level.

FarzadHayat
FarzadHayat approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@FarzadHayat FarzadHayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FarzadHayat FarzadHayat FarzadHayat approved these changes

@ztomaszyk ztomaszyk ztomaszyk approved these changes

@LewisAtTiny LewisAtTiny LewisAtTiny approved these changes

@abhinavgandham abhinavgandham Awaiting requested review from abhinavgandham abhinavgandham is a code owner

@soritaheng soritaheng Awaiting requested review from soritaheng soritaheng is a code owner

@EkimChau EkimChau Awaiting requested review from EkimChau EkimChau is a code owner automatically assigned from tinymce/documentation-team

@Skylite73 Skylite73 Awaiting requested review from Skylite73 Skylite73 is a code owner automatically assigned from tinymce/documentation-team

Assignees
No one assigned
Labels
upcoming release Documentation for features currently under development/QA
Projects
None yet
Milestone
TinyMCE 7.5
Development

Successfully merging this pull request may close these issues.
4 participants
@kemister85 @FarzadHayat @ztomaszyk @LewisAtTiny