-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editor as directive #342
base: main
Are you sure you want to change the base?
Conversation
Hi @javiermarinros, thanks for putting in the time to make this PR. I think it's an interesting idea and novel. In my opinion though I think it's quite narrow in its use case. That's my thoughts on it for now. If others think differently or if there's significant want/need for this in the future we'll certainly consider it. |
Hi @danoaky-tiny thank you for your review. Just some remarks:
|
I separated the
Editor
component logic into a directive and a component that inherits from it.With this change, the directive can be directly attached to a host element like a
textarea
without having to create custom nodes.Example:
It should be compatible with all previous implementations, as the component have the same inputs and outputs as it used to have, and the directive has mostly the same API as the component, except for the
id
andtagName
inputs.