Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINY-10708: Suppress bedrock logs in remote testing #142

Merged
merged 11 commits into from
Mar 11, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented Mar 5, 2024

Related Ticket: TINY-10708

Description of Changes:

  • Reduce logs when on CI to 10% intervals.
  • Cursor is no longer moved (or at least tries to) when on CI, so logs are just normally printed.

Pre-checks:

  • Changelog entry added
  • package.json versions have not been changed (done by Lerna on release)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

And only update HUD when `ResultData` has changed
Copy link
Member

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Rather than using remote as the flag, can you please use a TTY check and maybe look for the CI environment variable?

I want this change for all CI, including headless tests.

Copy link
Member

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 👍

@danoaky-tiny danoaky-tiny marked this pull request as ready for review March 5, 2024 22:47
@danoaky-tiny danoaky-tiny requested a review from a team as a code owner March 5, 2024 22:47
modules/server/src/main/ts/bedrock/cli/Hud.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@danoaky-tiny danoaky-tiny merged commit a58099b into master Mar 11, 2024
5 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/TINY-10708 branch March 11, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants