TINY-11177: Only update the HUD once for batch results, instead of on…

…ce for every result
tinymce · Sep 16, 2024 · 5e55c44 · 5e55c44
1 parent c4359e8
commit 5e55c44
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/modules/server/src/main/ts/bedrock/server/Controller.ts b/modules/server/src/main/ts/bedrock/server/Controller.ts
@@ -133,10 +133,8 @@ export const create = (stickyFirstSession: boolean, overallTimeout: number, test
     updateHud(session);
   };
 
-  const recordTestResult = (id: string, name: string, file: string, passed: boolean, time: string, error: TestErrorData | null, skipped: string) => {
-    const now = Date.now();
-    const session = getSession(id);
-    const record = { name, file, passed, time, error, skipped };
+  const recordTestResult = (session: TestSession, record: TestResult) => {
+    const {name, file} = record;
     if (session.lookup[file] !== undefined && session.lookup[file][name] !== undefined) {
       // rerunning a test
       session.results[session.lookup[file][name]] = record;
@@ -146,9 +144,6 @@ export const create = (stickyFirstSession: boolean, overallTimeout: number, test
       session.lookup[file][name] = session.results.length;
       session.results.push(record);
     }
-    session.updated = now;
-    session.done = false;
-    updateHud(session);
   };
 
   const recordTestResults = (id: string, results: TestResult[]) => {
@@ -163,9 +158,12 @@ export const create = (stickyFirstSession: boolean, overallTimeout: number, test
       };
     }
     results.forEach(
-      ({name, file, passed, time, error, skipped}) =>
-        recordTestResult(id, name, file, passed, time, error, skipped)
+      (record) =>
+        recordTestResult(session, record)
     );
+    session.updated = now;
+    session.done = false;
+    updateHud(session);
   };
 
   const recordDone = (id: string, error?: string) => {