Fix allownil propagated to byte slices as slice elements #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`[][]byte` would assume that the byte slices had allownil set. This would cause an extra `if x == nil {x = make([]byte,0)}` to be inserted on elements.
Regression from tinylib#363
klauspost
added a commit
to klauspost/msgp
that referenced
this pull request
Oct 22, 2024
Similar to tinylib#374 map `[]byte` elements would also inherit allownil unintentionally.
klauspost
added a commit
that referenced
this pull request
Oct 22, 2024
* Fix allownil on maps elements * Also set for primitives. Similar to #374 map `[]byte` elements would also inherit allownil unintentionally.
|
@klauspost Could a new release be made with this fix? |
|
@klauspost Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[][]bytewould assume that the byte slices had allownil set. This would cause an extraif x == nil {x = make([]byte,0)}to be inserted on elements.Regression from #363