Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence stderr in tests #1708

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Silence stderr in tests #1708

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f76126e
Silence stderr in tests for child exceptions
jotaen Dec 18, 2023
7cfeb1d
💅
jotaen Dec 18, 2023
f4be1be
Reference Github issue
jotaen Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions app/execute_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import contextlib
import io
import time
import unittest
Expand Down Expand Up @@ -35,6 +36,13 @@ def return_string():
return 'Done!'


@contextlib.contextmanager
def silence_stderr():
"""Silences stderr to avoid polluting the terminal output of the tests."""
with mock.patch('sys.stderr', io.StringIO()):
yield None


class ExecuteTest(unittest.TestCase):

def test_process_with_result_child_completed(self):
Expand All @@ -58,7 +66,7 @@ def test_process_with_result_child_not_completed(self):
def test_process_with_result_child_exception(self):
# Silence stderr while the child exception is being raised to avoid
# polluting the terminal output.
with mock.patch('sys.stderr', io.StringIO()):
with silence_stderr():
process = execute.ProcessWithResult(target=raise_exception,
daemon=True)
process.start()
Expand Down Expand Up @@ -89,12 +97,14 @@ def test_execute_with_timeout_return_value(self):
self.assertEqual('Done!', return_value)

def test_execute_with_timeout_child_exception(self):
with self.assertRaises(Exception) as ctx:
execute.with_timeout(raise_exception, timeout_in_seconds=0.5)
with silence_stderr():
with self.assertRaises(Exception) as ctx:
execute.with_timeout(raise_exception, timeout_in_seconds=0.5)
self.assertEqual('Child exception', str(ctx.exception))

def test_background_thread_ignores_function_successful(self):
self.assertEqual(None, execute.background_thread(return_string))

def test_background_thread_ignores_function_exception(self):
self.assertEqual(None, execute.background_thread(raise_exception))
with silence_stderr():
self.assertEqual(None, execute.background_thread(raise_exception))