Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

includes tds_fdw libraries #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

includes tds_fdw libraries #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ RUN set -eux; \
RUN apt-get update && apt-get install -y dumb-init daemontools

RUN apt-get update \
&& apt-get install -y postgresql-common pgbouncer pgbackrest lz4 libpq-dev libpq5 pgtop \
&& apt-get install -y postgresql-common pgbouncer pgbackrest lz4 libpq-dev libpq5 pgtop libsybdb5 freetds-dev freetds-common gnupg gcc make \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding gnupg gcc make and all the others on this line isn't great.

On line 114 make, gmake, gcc and gpg are already installed, adding a separte RUN command after that line that would would IMHO be preferable over this. Somewhere after lines 127 seems more appropriate, because at that point many postgresql packages are already installed.

# forbid creation of a main cluster when package is installed
&& sed -ri 's/#(create_main_cluster) .*$/\1 = false/' /etc/postgresql-common/createcluster.conf

Expand Down