Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progress race #268

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix progress race #268

merged 3 commits into from
Sep 20, 2023

Conversation

timcassell
Copy link
Owner

Fixes #267

@timcassell
Don't call HandleNext if PromiseProgress has not already been awaited.
83e7446 
Optimize HandleNext calls from PromiseConfigured.
@timcassell timcassell added the bug Something isn't working label Sep 19, 2023
@timcassell timcassell added this to the v2.6.0 milestone Sep 19, 2023
@timcassell timcassell self-assigned this Sep 19, 2023
@timcassell timcassell marked this pull request as ready for review September 19, 2023 16:14
@timcassell timcassell merged commit 70b5f07 into master Sep 20, 2023
124 checks passed
@timcassell timcassell deleted the fix-progress-race branch September 20, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timcassell timcassell

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.

Race condition
1 participant
@timcassell