feat: handle unassigned shortcuts gracefully

timbru31 · Jan 24, 2025 · 512c4be · 512c4be
1 parent f84ad90
commit 512c4be
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/src/_locales/de/messages.json b/src/_locales/de/messages.json
@@ -1,6 +1,6 @@
 {
   "version": {
-    "message": "Quick JIRA v1.0.0",
+    "message": "Quick JIRA v2.0.0",
     "description": "Please do not alter this value"
   },
   "options": {
@@ -110,5 +110,9 @@
   "placeholder": {
     "message": "Gib die Ticket ID ein",
     "description": "Placeholder text for the input field"
+  },
+  "unassigned": {
+    "message": "Nicht zugewiesen",
+    "description": "Text for unassigned shortcut"
   }
 }
diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json
@@ -1,6 +1,6 @@
 {
   "version": {
-    "message": "Quick JIRA v1.0.0",
+    "message": "Quick JIRA v2.0.0",
     "description": "Please do not alter this value"
   },
   "options": {
@@ -110,5 +110,9 @@
   "placeholder": {
     "message": "Enter ticket ID",
     "description": "Placeholder text for the input field"
+  },
+  "unassigned": {
+    "message": "Unassigned",
+    "description": "Text for unassigned shortcut"
   }
 }
diff --git a/src/js/options.ts b/src/js/options.ts
@@ -108,13 +108,13 @@ const loadShortcuts = async () => {
           switch (command.name) {
             case '_execute_action':
             case '_execute_browser_action':
-              listItem.textContent = `Popup: ${command.shortcut ?? 'Ctrl+Shift+K'}`;
+              listItem.textContent = `Popup: ${command.shortcut === '' ? _browser.i18n.getMessage('unassigned') : (command.shortcut ?? 'Ctrl+Shift+K')}`;
               break;
             case 'open-ticket-in-new-tab':
-              listItem.textContent = `${_browser.i18n.getMessage('openInNewTab')}: ${command.shortcut ?? 'Alt+Shift+K'}`;
+              listItem.textContent = `${_browser.i18n.getMessage('openInNewTab')}: ${command.shortcut === '' ? _browser.i18n.getMessage('unassigned') : (command.shortcut ?? 'Alt+Shift+K')}`;
               break;
             case 'open-ticket-in-current-tab':
-              listItem.textContent = `${_browser.i18n.getMessage('openInCurrentTab')}: ${command.shortcut ?? 'Alt+K'}`;
+              listItem.textContent = `${_browser.i18n.getMessage('openInCurrentTab')}: ${command.shortcut === '' ? _browser.i18n.getMessage('unassigned') : (command.shortcut ?? 'Alt+K')}`;
               break;
           }
           shortcutList.appendChild(listItem);