Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Add finger present API and bit. Update README #212

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

secworks
Copy link
Contributor

@secworks secworks commented Apr 22, 2024

This PR adds the ability for SW to read the sampled input from the touch sensor. That allows SW to detect a finger present, and with the aid of the timer measure touch events of different lengths.

Maybe closes #214

@secworks secworks added enhancement New feature or request fpga Related to the FPGA design labels Apr 22, 2024
@secworks secworks requested review from dehanj and mchack-work April 22, 2024 13:38
@secworks secworks self-assigned this Apr 22, 2024
@mchack-work mchack-work linked an issue May 16, 2024 that may be closed by this pull request
@dehanj dehanj force-pushed the add_finger_present branch from 32837fe to c96363a Compare May 20, 2024 08:57
@dehanj
Copy link
Member

dehanj commented May 20, 2024

Rebased on main and added the addresses in tk1_mem.h.

Also did an implementation in tkey-libs, see the draft PR.

@dehanj dehanj changed the title Add finger present API and bit. Update README PoC: Add finger present API and bit. Update README Aug 22, 2024
@mchack-work
Copy link
Member

We have discussed elsewhere how a finger present API is probably incompatible with biometrics.

Do we keep this around as a Draft PR? Even a branch? Or just close and delete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fpga Related to the FPGA design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal intention of system reset to firmware Device app to test hold touch
3 participants