-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail on windows #122
Comments
Got zip working. A few weird things I noticed: This is what I had to change for tests to pass: It seems like sometimes the resolved datasource file is Here you can see the JSON of what was expected (according to your current tests) vs what windows actually saw: |
@BHare1985 great work getting this going. Take a look at using the 'rimraf' module for deleting directories with files. Also it sure why you are seeing the dfferent cache path results. Can you create a pull request for your change as a next step? that way we will be able to see if they are passing on linux via travis. |
@springmeyer The issue isn't deleting directories with files, it's that it shouldn't technically have a file in the directory since it is using Also I am not sure what good it would be to pull request the hacked up tests that pass on windows. I am 99% confident something weird is happening on windows and caching is not correct. None the less I will make a pull request for the good changes I did but not the ones where I have to modify locations of caches. It's also worth mentioning that my intuition that cache is not working right is because my grainstore is failing tests because millstone on windows is taking too long and the 100 ms timeouts in the tests for grainstore fail because millstone takes too long.
Ill have a pull request of my good fixes to the testing |
Well one test failed from wget and the other failed but predictably I think. Seems you have a kind of chroot for testing and it failed that way. Most importantly is that your |
I finally came back to this and realize the issue with unlink is basically the same one as shelljs/shelljs#49 (node links in there) TLDR; when you unlink its marked as deleted but not actually deleted by windows. Thats why I get rmdirSync |
See this commit on what I changed to make the tests windows-friendly: BHare1985@02beb86
I ignored the zip tests, as I am not supporting zip files right now (mapbox/node-zipfile#58 ). Will apply the fix there when I find time later tonight, and fix any tests for zips.
I am currently having an issue with support.js'
rm
function not removingabsolute.json
from the copypath in util afterEach hook.rmdirSync
Saying directory is not empty when trying to delete copypath (because absolute.json is still there, despite getting aunlinkSync
)Will update this issue in the next few days as I get zip working and figure out the
rm
issue.The text was updated successfully, but these errors were encountered: