Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more datasources #334

Closed
BHare1985 opened this issue May 11, 2015 · 6 comments
Closed

Add more datasources #334

BHare1985 opened this issue May 11, 2015 · 6 comments

Comments

@BHare1985
Copy link

Since the underlying map image rendering is Mapnik, would it be possible to utilize mapnik's OGR support to allow non postgres databases? I feel this would really add to the value of Windshaft.

I would love MSSQL support.

@rochoa
Copy link
Contributor

rochoa commented May 11, 2015

Although Windshaft's motto has been "A Node.js map tile server for PostGIS with CartoCSS styling." for a while it's true that recently we've started to implement other datasources. For example the HTTP, plain renderers.

So it should be possible to implement a mapnik's OGR with other datasource/database as backend as far as it follows the following spec: https://github.com/CartoDB/Windshaft/blob/master/lib/windshaft/renderers/README.md

You can check how the HTTP renderer is built following those interfaces: https://github.com/CartoDB/Windshaft/tree/master/lib/windshaft/renderers/http

It would be wonderful if you can prototype something with OGR, I would be more than happy to help 👐

@rochoa
Copy link
Contributor

rochoa commented Jun 11, 2015

Hey Brian,

Did you have the time to prototype something? 👂

raul

@BHare1985
Copy link
Author

Actually, I forked from an older but more manageable version of Windshaft and got that to work using the newest mapnik which allows me complete flexibility. Just had to get grainstore and all its depencies to be windows friendly.

https://github.com/BHare1985/Windshaft

I'd love to spend some time on getting the latest Windshaft with mapnik 2.x to accept non-postgis, but don't have the time right now. This can be closed (if you want) because my needs have been met.

@rochoa
Copy link
Contributor

rochoa commented Jun 11, 2015

Cool! Thanks for letting me know.

Just to understand better why you had to fork: what problems did you find with the current approach? I'm thinking in making some changes and would like to hear from other users.

@BHare1985
Copy link
Author

Well it was mostly a time constraint. Latest windshaft is a beast (hard to manage but good efficiency), and I just needed a relatively simple and semi-efficient method for doing dynamic map generation that works with Windows. Everything in Windshaft is geared at linux installation and use, figured this was the easier route.

I am still having issues with millstone and windows ( tilemill-project/millstone#122 ) and I had to submit a few issue requests to mapbox team for their zip library (they are great).

Instead of relying on hiredis for redis-mpool, I just opted for the native javascript method, which was only a performance decrease of like 10-20% but it was like instead of doing 300,000 read/write a second you can only do 270,000 a second, which I figured wouldn't hurt my bottom line for the specific use-case of redis

@rochoa
Copy link
Contributor

rochoa commented Jun 12, 2015

Nice to hear from you. Your choices totally make sense based on your comments! 👍 And yes, it's not a problem to use redis js impl.

Again, thanks for sharing your insights. At some point Windshaft should be more like a library than a library+service, so it could be easier to integrate and reuse in other projects.

@rochoa rochoa closed this as completed Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants