raft: next index shall be larger than match index #557
+81
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, seems the test case is missing. |
|
Do I need to add test here? |
|
You also need to port the test case from the original PR. |
|
This test case needs to be added to harness/tests/integreation_cases/test_raft.rs right? |
|
Yes. |
…alue to be less than or equal to the match value in the probe state Signed-off-by: wego1236 <[email protected]>
Signed-off-by: wego1236 <[email protected]>
|
I may need some help, the test case I wrote modelled after etcd doesn't achieve the same results as they do, this test case may need your help to complete it. When I tried it, I found that in some cases etcd and raft-rs produced different results, so I may not be able to simply copy the corresponding test cases. |
Signed-off-by: wego1236 <[email protected]>
|
I'm not familiar with rust, maybe for me this test case needs to know a bit too much, if it's easier for you, could you help me to modify it a bit |
chagelo
reviewed
Nov 16, 2024
| assert_eq!(m.reject, false); | ||
| assert_eq!(m.index, 2); | ||
| let _ = r1.step(m); | ||
| let _ = expect_one_message(&mut r1); |
There was a problem hiding this comment.
Suggested change
| let _ = expect_one_message(&mut r1); |
You may need to remove this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leader shall always replicate its log from a index larger than corresponding match index. Note that this is not a correctness issue, but rather an optimization in case of message reordering.
Related: #555