Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lenovo X1 Carbon Gen 12 support #965

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Lenovo X1 Carbon Gen 12 support #965

wants to merge 2 commits into from
+206 −5

Conversation

tervis-unikie
Copy link
Contributor

@tervis-unikie tervis-unikie commented Jan 24, 2025 •
edited
Loading

Description of changes

Added new target for gen12.
Added pass-through for gen12 devices.
Enable access to video bios table (VBT) to gui-vm.
Requires update to microvm side to enable passing of extra arguments: astro/microvm.nix#325

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • [N/A] Tested on Jetson Orin NX or AGX aarch64
    • [N/A] Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    • lenovo-x1-carbon-gen12-debug
    • lenovo-x1-carbon-gen12-release
  • Is this a new feature
    • List the test steps to verify:
    • Build a Ghaf gen12 target
    • Test that Ghaf works on a Lenovo X1 Carbon Gen 12 laptop
  • If it is an improvement how does it impact existing functionality?

@tervis-unikie tervis-unikie temporarily deployed to internal-build-workflow January 24, 2025 10:38 — with GitHub Actions Inactive
tervis-unikie and others added 2 commits January 24, 2025 14:16
@tervis-unikie @vunnyso
Add Lenovo X1 Carbon Gen 12 support
97b16a8 
Signed-off-by: Tero Tervala <[email protected]>
@vunnyso
graphics: Enable gpu passthrough
9b65f59 
Pass "x-igd-opregion=on" deviceExtraArgs to graphics
pci device which helps to enable opregion which in-turn
enable access to video bios table (VBT) to gui-vm.
So qemu will have access to display parameters which
are needed in Link training for the Gen 12 eDP panel.

Signed-off-by: Vunny Sodhi <[email protected]>
@vunnyso vunnyso temporarily deployed to internal-build-workflow January 24, 2025 12:17 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tervis-unikie @brianmcgillion @vunnyso