Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable systemd hardened configs in gui-vm #956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable systemd hardened configs in gui-vm #956

wants to merge 1 commit into from
+4 −4

Conversation

gngram
Copy link
Contributor

@gngram gngram commented Jan 21, 2025

Description of changes

  • Fixed dynamic user login issue with hardened systemd configs.
  • Mounting user home requires admin capability in systemd-udevd, so allowed it.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
      • Login to gui-vm and see if everything is working fine.
  • If it is an improvement how does it impact existing functionality?

@gngram gngram temporarily deployed to internal-build-workflow January 21, 2025 08:31 — with GitHub Actions Inactive
@ktusawrk
Copy link
Collaborator

Failed ghaf-pre-merge-pipeline build 328 is not related to this PR. There was a glitch in the pre-merge-pipeline itself. This failed build does not prevent merging this PR.

@brianmcgillion brianmcgillion self-requested a review January 21, 2025 15:19
@gngram
Enable systemd hardened configs in gui-vm
5b7e633 
- Fixed dynamic user login issue.
- Mounting user home requires admin capability, so allowed it.

Signed-off-by: Ganga Ram <[email protected]>
@gngram gngram force-pushed the pr__dynamic-user-login-issue branch from 9fe5ac2 to 5b7e633 Compare January 24, 2025 12:21
@gngram gngram temporarily deployed to internal-build-workflow January 24, 2025 12:21 — with GitHub Actions Inactive
@gngram
Copy link
Contributor Author

gngram commented Jan 24, 2025

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vunnyso vunnyso vunnyso approved these changes

@mbssrc mbssrc mbssrc approved these changes

@brianmcgillion brianmcgillion Awaiting requested review from brianmcgillion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gngram @ktusawrk @brianmcgillion @mbssrc @vunnyso