Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all workflow builds to remote builders #865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

henrirosten
Copy link
Collaborator

@henrirosten henrirosten commented Oct 26, 2024

Description of changes

  • Stop building any ghaf targets directly on github-hosted runners in the build.yml workflow. Instead, delegate all builds to remote builders as configured in github action variable BUILDER_MACHINE_CONFIG. Currently, all builds will be delegated to hetzarm.vedenemo.dev (aarch64) and build4.vedenemo.dev (x86_64). We hope this change also makes it possible to start building ghaf's biggest targets (package-lenovo-x1-carbon-gen11-debug and package-generic-x86_64-debug) in the build.yml github action. Adding those targets to the build.yml will be done later in a follow-up PR.
  • Make builds in build.yml start using binary caches as configured in the ghaf flake by setting the accept-flake-config = true and by making the github action user 'runner' a nix trusted user on the github hosted runner. This way, we don't have to change the build.yml every time we change the binary cache config in ghaf flake, but the github action builds will automatically follow the ghaf flake configuration.
  • Update cachix/install-nix-action on all workflows to its current latest version.

This change was tested in a fork at: https://github.com/henrirosten/ghaf.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@henrirosten henrirosten deployed to internal-build-workflow October 26, 2024 06:23 — with GitHub Actions Active
@henrirosten henrirosten marked this pull request as ready for review October 26, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant