Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable USB controller for AppVMs #860

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

nesteroff
Copy link
Contributor

@nesteroff nesteroff commented Oct 22, 2024

Description of changes

QEMU VMs require a USB controller for hotplugging to work. MicroVM.nix automatically enables the USB controller when any static USB devices are added or when graphics.enable is set to true, but this is not the case for all AppVMs. For example, after the internal USB camera passthrough to ChromiumVM was commented out, there is no USB controller present and USB camera hotplugging no longer works. This fix addresses that issue.

Fixes SSRCSP-5500.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

Connect a USB camera to Lenovo X1 and make sure it's available in Chromium.

@nesteroff nesteroff temporarily deployed to internal-build-workflow October 22, 2024 12:29 — with GitHub Actions Inactive
@nesteroff nesteroff added the Needs Testing CI Team to pre-verify label Oct 22, 2024
@milva-unikie
Copy link

Tested with Lenovo-X1 that usb camera works again in Chromium. Thanks for the quick fix!

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Oct 23, 2024
@brianmcgillion brianmcgillion merged commit 0396a4f into tiiuae:main Oct 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants