Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable the appflowy #839

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

brianmcgillion
Copy link
Collaborator

unused and unloved

can be used as a reference of how we currently have to enable apps and app vms.


Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    carbon x1 MVP

  • Is this a new feature

    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

removes appflowy. it should not be enabled microvm -l in the host should not show it and it should be removed from the launcher.

Signed-off-by: Brian McGillion <[email protected]>
@brianmcgillion brianmcgillion merged commit 77cbd40 into tiiuae:main Oct 9, 2024
13 of 14 checks passed
@brianmcgillion brianmcgillion deleted the disable-appflowy branch October 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants