Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvp-user-trial: Enable autolock on system boot #825

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

vunnyso
Copy link
Contributor

@vunnyso vunnyso commented Oct 7, 2024

Description of changes

Autolock the system by default after boot up.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

## Issue
Brightness will be minimum at system boot

@vunnyso vunnyso temporarily deployed to internal-build-workflow October 7, 2024 11:36 — with GitHub Actions Inactive
@clayhill66 clayhill66 added the Needs Testing CI Team to pre-verify label Oct 7, 2024
@vunnyso vunnyso temporarily deployed to internal-build-workflow October 7, 2024 12:06 — with GitHub Actions Inactive
@milva-unikie
Copy link

milva-unikie commented Oct 7, 2024

Tested on Lenovo-X1 (nixos-rebuild switch)

  • User is asked to login after boot
  • Autolock locks the screen after 5 minutes of inactivity
  • Test-automation passes
  • (After the fix brightness is at 100 % at boot)

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Oct 7, 2024
Autolock the system by default after boot up.

Signed-off-by: Vunny Sodhi <[email protected]>
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow October 7, 2024 13:39 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion merged commit 4cee543 into tiiuae:main Oct 7, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants