Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postboot command for ZFS installation. #813

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

unbel13ver
Copy link
Contributor

@unbel13ver unbel13ver commented Oct 1, 2024

This fix resolves SSRCSP-5296.
Previously, zfspool has not been expanded for the system, installed on nvme drive. The issue was so that a partition's parent disk name is not resolved correctly for /dev/nvme0n1 device.

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

Install the system and check ZFS pool size with zpool status or zpool list. It must occupy all the free space available on the disk.

  • List all targets that this applies to: Lenovo-X1
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

This fix resolves SSRCSP-5296.

Signed-off-by: Ivan Nikolaenko <[email protected]>
@unbel13ver unbel13ver temporarily deployed to internal-build-workflow October 1, 2024 13:27 — with GitHub Actions Inactive
@unbel13ver unbel13ver marked this pull request as ready for review October 1, 2024 13:29
@brianmcgillion
Copy link
Collaborator

size of the linux filesystem increased from 14 to 952.9 GB

@brianmcgillion brianmcgillion merged commit 110a2ad into tiiuae:main Oct 1, 2024
13 of 14 checks passed
@humaidq-tii humaidq-tii mentioned this pull request Oct 2, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants