-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zoom app in comms-vm #810
base: main
Are you sure you want to change the base?
Conversation
modules/reference/appvms/comms.nix
Outdated
@@ -87,7 +88,8 @@ in | |||
applications = lib.mkForce '' | |||
{ | |||
"element": "${config.ghaf.givc.appPrefix}/run-waypipe ${config.ghaf.givc.appPrefix}/element-desktop --enable-features=UseOzonePlatform --ozone-platform=wayland", | |||
"slack": "${config.ghaf.givc.appPrefix}/run-waypipe ${config.ghaf.givc.appPrefix}/chromium --enable-features=UseOzonePlatform --ozone-platform=wayland --app=https://app.slack.com/client ${config.ghaf.givc.idsExtraArgs}" | |||
"slack": "${config.ghaf.givc.appPrefix}/run-waypipe ${config.ghaf.givc.appPrefix}/chromium --enable-features=UseOzonePlatform --ozone-platform=wayland --app=https://app.slack.com/client ${config.ghaf.givc.idsExtraArgs}", | |||
"zoom": "${config.ghaf.givc.appPrefix}/run-waypipe ${config.ghaf.givc.appPrefix}/env XDG_CURRENT_DESKTOP=wlroots XDG_SESSION_TYPE=wayland LD_LIBRARY_PATH=$LD_LIBRARY_PATH:${pkgs.zoom-us}/opt/zoom/Qt/lib/ ${pkgs.zoom-us}/opt/zoom/zoom" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, do you think it would make sense to move XDG_CURRENT_DESKTOP
and XDG_SESSION_TYPE
to the run-waypipe
script defined in appvm.nix
or perhaps even add them to the appvm's environment so that other apps can use them in the future?
Tested on Lenovo-X1 (flashed to the SSD) (commit: a4aeb0b) Issues:
-if you choose "Schedule" the "schedule meeting"-window appeared and is "loading" something, cannot close window. -you choose "host tools", "View", "mute" or "more"-option, the options are not visible totally: -if you choose from "... More"-option "Whiteboards", "notes", "clips", "meeting" or "mail" there appeared "Loading your.." nothing else. "Contacts" opened the contacts-page. Camera don't work, that was known issue. Working:
-all other ghaf apps can be launched |
zoom-us application is added into comms-vm with icon A launch script is created to add environment to waypipe Signed-off-by: Berk Arslan <[email protected]>
Description of changes
zoom-us application is added into comms-vm with icon
A launch script is created to add environment to waypipe
Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Instructions for Testing
x86_64