Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom app in comms-vm #810

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add zoom app in comms-vm #810

wants to merge 1 commit into from

Conversation

Nerox9
Copy link
Contributor

@Nerox9 Nerox9 commented Oct 1, 2024

Description of changes

zoom-us application is added into comms-vm with icon
A launch script is created to add environment to waypipe

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    • Lenovo X1 x86_64
  • Is this a new feature
    • List the test steps to verify:
      • Launch ghaf and click to ghaf launcher on the left bottom corner of the taskbar
      • Run Zoom app by clicking the app icon
      • Login and check the functionality of Zoom application
  • If it is an improvement how does it impact existing functionality?

@@ -87,7 +88,8 @@ in
applications = lib.mkForce ''
{
"element": "${config.ghaf.givc.appPrefix}/run-waypipe ${config.ghaf.givc.appPrefix}/element-desktop --enable-features=UseOzonePlatform --ozone-platform=wayland",
"slack": "${config.ghaf.givc.appPrefix}/run-waypipe ${config.ghaf.givc.appPrefix}/chromium --enable-features=UseOzonePlatform --ozone-platform=wayland --app=https://app.slack.com/client ${config.ghaf.givc.idsExtraArgs}"
"slack": "${config.ghaf.givc.appPrefix}/run-waypipe ${config.ghaf.givc.appPrefix}/chromium --enable-features=UseOzonePlatform --ozone-platform=wayland --app=https://app.slack.com/client ${config.ghaf.givc.idsExtraArgs}",
"zoom": "${config.ghaf.givc.appPrefix}/run-waypipe ${config.ghaf.givc.appPrefix}/env XDG_CURRENT_DESKTOP=wlroots XDG_SESSION_TYPE=wayland LD_LIBRARY_PATH=$LD_LIBRARY_PATH:${pkgs.zoom-us}/opt/zoom/Qt/lib/ ${pkgs.zoom-us}/opt/zoom/zoom"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, do you think it would make sense to move XDG_CURRENT_DESKTOP and XDG_SESSION_TYPE to the run-waypipe script defined in appvm.nix or perhaps even add them to the appvm's environment so that other apps can use them in the future?

@johannarautanen
Copy link

johannarautanen commented Oct 2, 2024

Tested on Lenovo-X1 (flashed to the SSD) (commit: a4aeb0b)

Issues:

  • cannot close application via "join a meeting"-page-> the windows disappeared, but when checking with alt+tab zoom's start-window is still available.
  • cannot maximize the "joint a meeting"-page, small page just move to the left corner
  • From "Sign in"-page cannot sign into "Facebook", "Google" or "apple"
  • when you have active meeting-call ongoing and you tap the "share" or "start video"-buttons, ZOOM crashed and needed to reboot the ghaf to be able to open ZOOM-app again:
    camera.txt
    share.txt

-if you choose "Schedule" the "schedule meeting"-window appeared and is "loading" something, cannot close window.
-and cannot close the main window either, no matter which "x"-button you choose in the upright > window disappeared, but with ALT+tab you can see that the "zoom workplace-Free account" is still there.
So reboot needed to get rid of "schedule"- and "zoom workplace-Free account"-windows.
screenshot-20241002-08-21-46
screenshot-20241002-09-00-04

-you choose "host tools", "View", "mute" or "more"-option, the options are not visible totally:
screenshot-20241002-08-33-15

-if you choose from "... More"-option "Whiteboards", "notes", "clips", "meeting" or "mail" there appeared "Loading your.." nothing else. "Contacts" opened the contacts-page.
-when you have active meeting call and you choose the "more" and for example "notes" -> zoom crashed. This time you can start the ZOOM again, don't need reboot GHAF this time.
notes.txt

Camera don't work, that was known issue.

Working:
-able to sign in to ZOOM and create meeting call
-internal, usb, 3,5mm and bluetooth audio works.

  • can send invitation to the meeting
  • able to get the invitation and join the meeting
    -can chat with ZOOM chat during meeting
  • can react with emojis during meeting
    -can join the meeting with the meeting ID and password

-all other ghaf apps can be launched
-ci-test automation cases ok

@johannarautanen johannarautanen added bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR and removed Needs Testing CI Team to pre-verify labels Oct 2, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow October 3, 2024 12:09 — with GitHub Actions Inactive
zoom-us application is added into comms-vm with icon
A launch script is created to add environment to waypipe

Signed-off-by: Berk Arslan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants