Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the nm-launcher not found error #802

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

brianmcgillion
Copy link
Collaborator

@brianmcgillion brianmcgillion commented Sep 24, 2024

hmmmm. how it ever worked???


Description of changes

Fixes the nm-launcher path in the waybar so that it can be found.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    x1-carbon MVP user image

  • Is this a new feature

    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?
    Bug fix that just appeared from nowhere.

hmmmm. how it ever worked???

Signed-off-by: Brian McGillion <[email protected]>
Copy link
Contributor

@kajusnau kajusnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the correct way, works also in ewwbar

@brianmcgillion brianmcgillion merged commit bf81393 into tiiuae:main Sep 27, 2024
14 checks passed
@brianmcgillion brianmcgillion deleted the fix-nm-launcher branch September 27, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants