Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double RAM settings for ChromiumVM #786

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

vadika
Copy link
Contributor

@vadika vadika commented Sep 12, 2024

Description of changes

Double RAM amount for ChromiumVM -- 3072Mb was too tight and causing OOM watchdog to kill browser.
Fix for SP-5195 issue.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@clayhill66
Copy link
Collaborator

I think the same change needs to be done to Business VM as well

@vadika
Copy link
Contributor Author

vadika commented Sep 16, 2024

I think the same change needs to be done to Business VM as well

There were no complains from testing team concerning BusinessVM, so lets do burn system resources step by step :)

@humaidq-tii
Copy link
Member

I am adding a feature that requires at least 8 GB free, so keep some left for me :)

@vadika vadika temporarily deployed to internal-build-workflow September 16, 2024 19:37 — with GitHub Actions Inactive
@vadika
Copy link
Contributor Author

vadika commented Sep 16, 2024

I think the same change needs to be done to Business VM as well

There were no complains from testing team concerning BusinessVM, so lets do burn system resources step by step :)

Because of complaints, doubled RAM for BusinessVM also.

@barnabakos
Copy link
Collaborator

barnabakos commented Sep 20, 2024

1 commit: 7d6992a
rebased to current tip of Ghaf main without conflicts: 5c27067

platform: Lenovo X1 Carbon; flash script

  • ci-test-automation suite: ok
  • starting apps: ok
  • regression / ad-hoc testing: ok

works:

  • basic browser usage is ok

notes:

  • it is not clearly stated what & how to check; and then what should be expected, so in testing:

    • consumed 1.5G of memory from chroumium-vm: dd if=/dev/random of=file
    • opened 6 (or 7) youtube tabs with random movies, full quality, x2 speed

    -> browser crashed in about 15 minutes

issues on Lenovo X1 Carbon:

  • it is possible to crash the browser; however it is not clear how much stress should it handle

@barnabakos barnabakos removed the Needs Testing CI Team to pre-verify label Sep 20, 2024
@brianmcgillion brianmcgillion merged commit 7a89d54 into tiiuae:main Sep 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants