Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerControl over ssh #406

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

baz2142
Copy link
Contributor

@baz2142 baz2142 commented Dec 7, 2023

Description of changes

This PR introduces:

  • The package PowerControl, which provides scripts to power control the host via ssh;
  • Refactored ssh keys generation and sharing on Lenovo X1 target
  • Add poweroff and reboot buttons on Lenovo X1 host in GUI

Works only on debug builds so far -- we need ssh-connection in release builds as well

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Build debug target on Lenovo X1, run it, you will see two buttons in GUI VM next to applications icons: PowerOff and Reboot. They should make described actions

@baz2142 baz2142 temporarily deployed to internal-build-workflow December 7, 2023 14:48 — with GitHub Actions Inactive
@brianmcgillion
Copy link
Collaborator

your main branch is 68 commits behind ghaf main, so a sync and rebase before a request to merge would be needed

@vilvo
Copy link
Contributor

vilvo commented Dec 13, 2023

Would you also please edit the description to follow https://github.com/tiiuae/ghaf/blob/main/.github/pull_request_template.md ?
Easier for reviewers to evaluate how checklist items have been considered.

@baz2142 baz2142 self-assigned this Dec 14, 2023
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 14, 2023 10:28 — with GitHub Actions Inactive
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 15, 2023 12:42 — with GitHub Actions Inactive
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 18, 2023 13:24 — with GitHub Actions Inactive
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 18, 2023 15:47 — with GitHub Actions Inactive
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 18, 2023 16:02 — with GitHub Actions Inactive
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 18, 2023 16:42 — with GitHub Actions Inactive
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 19, 2023 02:18 — with GitHub Actions Inactive
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 19, 2023 02:42 — with GitHub Actions Inactive
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 19, 2023 09:59 — with GitHub Actions Inactive
vilvo

This comment was marked as resolved.

@baz2142 baz2142 temporarily deployed to internal-build-workflow January 20, 2024 10:47 — with GitHub Actions Inactive
@baz2142 baz2142 temporarily deployed to internal-build-workflow January 20, 2024 11:09 — with GitHub Actions Inactive
@baz2142 baz2142 requested a review from vilvo January 21, 2024 12:17
@vilvo vilvo removed the Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin label Jan 29, 2024
@vilvo
Copy link
Contributor

vilvo commented Jan 29, 2024

@leivos-unikie - can you please test this is on Lenovo X1?

Copy link
Contributor

@leivos-unikie leivos-unikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ci-test-automation test suite passed
  • Apps launch by clicking the icons
  • Poweroff and Reboot buttons work

@leivos-unikie leivos-unikie added the Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon label Jan 30, 2024
@baz2142
Copy link
Contributor Author

baz2142 commented Jan 31, 2024

@vilvo, time to merge? @leivos-unikie has approved

@brianmcgillion
Copy link
Collaborator

can you resolve the merge conflict, by rebase and it can go in

The package provides scripts to power
control the host via ssh

Signed-off-by: Nikita Bazulin <[email protected]>
Also refactor ssh-stuff to make it reusable

Signed-off-by: Nikita Bazulin <[email protected]>
@brianmcgillion brianmcgillion merged commit e81ccfb into tiiuae:main Feb 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants