-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce to Waybar #386
Introduce to Waybar #386
Conversation
None of the demo apps launch by clicking their icons. Tried to launch zathura also from command line with the command found in /etc/waybar/config |
Tested again. Now apps launch except gala. |
Now all apps launch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nix inherit
related comment.
Testing-section of the PR requires improvement before I know who to test it.
- "Please note that it works with display as "wayland-0" in waypipe only in guivm.nix" <- what does this mean? The PR has no changes to
guivm.nix
and themain
-branchguivm.nix
has no clear indication on what to change to achieve this. Maybe the link is outdated?
Proposal on the PR Testing-section improvements:
- Detailed instruction to what exactly to change in the
guivm.nix
- use links to main branch (for example) and example of the exact setting to set - e.g.
waypipe-display = wayland-0
(<- is non-sense but hope you get the idea) - Detailed instruction to what to change in the guivm for labwc. For example,
profiles.graphics.compositor = "labwc"
- Rebuild with the settings changes from steps 1. and 2.
- Flash the image to SSD and boot.
Waybar configuration modified based on the default bar configuration and launchers added. Pulseaudio is added to guivm. Nmcli is used to get the network connection data in wifi-signal-strength script and nm-launcher connection structure is copied. Weston and waybar launchers are unified and name section added. Nerdfonts FiraCode is added. All the style and configuration files are created in weston.config.nix. Compositor and waypipe display name must be overriden as in comments in guivm.nix to use waybar properly. Signed-off-by: Berk Arslan <[email protected]>
The display name issue is fixed by the main branch update. The comment of testing is replaced with the steps. |
Description of changes
Waybar configuration modified based on the default bar configuration and launchers added.
Pulseaudio, network and battery/power adapter icons implemented.
Weston and waybar launchers are unified and name section added.
Checklist for things done
x86_64
aarch64
riscv64
nix flake check --accept-flake-config --allow-import-from-derivation
and it passesTesting