Add the whitepaper for zathura #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmcgillion
force-pushed
the
add-whitepaper-pdf
branch
from
505421a
to
950577f
Compare
brianmcgillion
force-pushed
the
add-whitepaper-pdf
branch
from
950577f
to
43d509d
Compare
mikatammi
reviewed
Sep 15, 2023
| stdenv, | ||
| pkgs, | ||
| lib, | ||
| ... |
There was a problem hiding this comment.
You are not using pkgs and lib, and you don't need ....
However, you could add zathura here instead of the above
mikatammi
reviewed
Sep 15, 2023
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp ${./Whitepaper.pdf} $out/Whitepaper.pdf | ||
| echo "zathura $out/Whitepaper.pdf" > $out/bin/run-zathura |
There was a problem hiding this comment.
Then if you add zathura to the "callPackage-style function call attribute set" above, you can say ${zathura}/bin/zathura here, instead of zathura.
mikatammi
reviewed
Sep 15, 2023
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp ${./Whitepaper.pdf} $out/Whitepaper.pdf |
There was a problem hiding this comment.
As you are doing full mkDerivation, you could say cp $src $out/Whitepaper.pdf instead
mikatammi
reviewed
Sep 15, 2023
| @@ -134,7 +136,7 @@ | |||
| } | |||
| { | |||
| name = "zathura"; | |||
| packages = [pkgs.zathura]; | |||
| packages = [pkgs.zathura (pkgs.callPackage ../user-apps/demo-pdf {})]; | |||
There was a problem hiding this comment.
You could also just put demo-pdf here instead of the pkgs.callPackage.
Also Note that you are using pkgs from the host and not from the appvm guest.
mikatammi
reviewed
Sep 15, 2023
brianmcgillion
force-pushed
the
add-whitepaper-pdf
branch
from
43d509d
to
be7a295
Compare
brianmcgillion
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
brianmcgillion
force-pushed
the
add-whitepaper-pdf
branch
from
be7a295
to
8760fa0
Compare
brianmcgillion
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
|
Just rebased for now |
Co-authored-by: Yuriy Nesterov <[email protected]> Co-authored-by: Ivan Nikolaenko <[email protected]> Signed-off-by: Brian McGillion <[email protected]>
brianmcgillion
force-pushed
the
add-whitepaper-pdf
branch
from
8760fa0
to
fc6d857
Compare
brianmcgillion
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
|
dump outdated patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pdf to showcase zathura in work. using the whitepaper from the demo image