-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the whitepaper for zathura #265
Conversation
505421a
to
950577f
Compare
950577f
to
43d509d
Compare
stdenv, | ||
pkgs, | ||
lib, | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not using pkgs
and lib
, and you don't need ...
.
However, you could add zathura
here instead of the above
installPhase = '' | ||
mkdir -p $out/bin | ||
cp ${./Whitepaper.pdf} $out/Whitepaper.pdf | ||
echo "zathura $out/Whitepaper.pdf" > $out/bin/run-zathura |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then if you add zathura
to the "callPackage-style function call attribute set" above, you can say ${zathura}/bin/zathura
here, instead of zathura.
|
||
installPhase = '' | ||
mkdir -p $out/bin | ||
cp ${./Whitepaper.pdf} $out/Whitepaper.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you are doing full mkDerivation, you could say cp $src $out/Whitepaper.pdf
instead
@@ -134,7 +136,7 @@ | |||
} | |||
{ | |||
name = "zathura"; | |||
packages = [pkgs.zathura]; | |||
packages = [pkgs.zathura (pkgs.callPackage ../user-apps/demo-pdf {})]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also just put demo-pdf
here instead of the pkgs.callPackage.
Also Note that you are using pkgs from the host and not from the appvm guest.
43d509d
to
be7a295
Compare
be7a295
to
8760fa0
Compare
Just rebased for now |
Co-authored-by: Yuriy Nesterov <[email protected]> Co-authored-by: Ivan Nikolaenko <[email protected]> Signed-off-by: Brian McGillion <[email protected]>
8760fa0
to
fc6d857
Compare
dump outdated patch |
Add a pdf to showcase zathura in work. using the whitepaper from the demo image