Refactoring mod structure #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work, thanks! I'm sorry for not getting to this sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR divides functions / hooks / etc. into different files and creates namespace for elevator stuff.
Might get more commits while PR is open as I continue working with this but I'll try to keep refactor branch in good shape and ready for possible merge.
If you think that merge like this is not happening then it would also be very nice to hear about that preferably sooner than later.
Changes made to actual code are minimal.
Relates with other things mentioned at #9
Towards fixing Elevator logout/disconnect failsafe