Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update actions/upload-artifact in Documentation.yaml #1520

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Jan 31, 2025

Description

Abstract

This pull-request is updating actions/upload-artifact from v3 to v4 in Documentation.yaml

Background

Since January 30th, actions/upload-artifact@v3 was no longer be able to use and preffered to use v4.
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

image

Details

None

References

The fixed workflow works fine!
https://github.com/tier4/scenario_simulator_v2/actions/runs/13064313151/job/36453875184?pr=1520

Destructive Changes

None

Known Limitations

None

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Jan 31, 2025
Copy link

github-actions bot commented Jan 31, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo requested a review from hakuturu583 January 31, 2025 01:06
@HansRobo HansRobo changed the title chore: update actions/upload-artifact in Documentation.yaml chore: update actions/upload-artifact in Documentation.yaml Jan 31, 2025
@hakuturu583 hakuturu583 merged commit c8611f5 into master Jan 31, 2025
11 checks passed
@github-actions github-actions bot deleted the chore/update-upload-artifact branch January 31, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants