-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: make flights data workaround explicit thus less scary #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Opening PRs from branches in the main repository will give a slightly better UX.
README.Rmd
Outdated
@@ -105,7 +105,7 @@ conflict_prefer("filter", "dplyr", quiet = TRUE) | |||
``` | |||
|
|||
The following code aggregates the inflight delay by year and month for the first half of the year. | |||
We use a variant of the `nycflights13::flights` dataset that works around an incompatibility with duckplyr. | |||
We use a variant of the `nycflights13::flights` dataset, where the timezone has been set to UTC to work around a [current limitation of duckplyr](https://duckplyr.tidyverse.org/dev/articles/limits.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same wording as in the help page, link will be translated.
I know... I do not have write access 😹 |
Co-authored-by: Kirill Müller <[email protected]>
Added write access. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if ba03203 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Thanks! |
Fix #488
Unfortunately this links to the dev website.