Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make flights data workaround explicit thus less scary #490

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Jan 24, 2025

Fix #488

Unfortunately this links to the dev website.

Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Opening PRs from branches in the main repository will give a slightly better UX.

R/flights.R Outdated Show resolved Hide resolved
README.Rmd Outdated
@@ -105,7 +105,7 @@ conflict_prefer("filter", "dplyr", quiet = TRUE)
```

The following code aggregates the inflight delay by year and month for the first half of the year.
We use a variant of the `nycflights13::flights` dataset that works around an incompatibility with duckplyr.
We use a variant of the `nycflights13::flights` dataset, where the timezone has been set to UTC to work around a [current limitation of duckplyr](https://duckplyr.tidyverse.org/dev/articles/limits.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same wording as in the help page, link will be translated.

@maelle
Copy link
Collaborator Author

maelle commented Jan 24, 2025

Opening PRs from branches in the main repository

I know... I do not have write access 😹

@krlmlr
Copy link
Member

krlmlr commented Jan 24, 2025

Added write access.

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if ba03203 is merged into main:

  • ✔️001_tpch_01: 23.7ms -> 24.4ms [-1.47%, +6.89%]
  • 🚀001_tpch_02: 72.8ms -> 68.8ms [-6.58%, -4.37%]
  • 🚀001_tpch_03: 40.8ms -> 40.1ms [-2.76%, -0.75%]
  • ✔️001_tpch_04: 22.8ms -> 23.2ms [-2.43%, +5.72%]
  • 🚀001_tpch_05: 59.6ms -> 58ms [-3.77%, -1.73%]
  • ✔️001_tpch_06: 14.3ms -> 14.5ms [-1.27%, +3.54%]
  • 🚀001_tpch_07: 78.4ms -> 75.6ms [-4.7%, -2.31%]
  • 🚀001_tpch_08: 104ms -> 98.3ms [-6.67%, -4.58%]
  • 🚀001_tpch_09: 76.8ms -> 73.5ms [-5.23%, -3.26%]
  • 🚀001_tpch_10: 50.9ms -> 49.4ms [-3.92%, -1.96%]
  • ✔️001_tpch_11: 34.5ms -> 33.6ms [-5.59%, +0.49%]
  • ✔️001_tpch_12: 28.1ms -> 27.8ms [-2.96%, +1.16%]
  • ✔️001_tpch_13: 26.5ms -> 25.9ms [-4.56%, +0.21%]
  • 🚀001_tpch_14: 21.5ms -> 20.6ms [-7.12%, -1.56%]
  • ✔️001_tpch_15: 33.1ms -> 32.7ms [-5.31%, +3.23%]
  • 🚀001_tpch_16: 41.3ms -> 40.1ms [-3.75%, -1.66%]
  • 🚀001_tpch_17: 27.6ms -> 26.2ms [-6.08%, -4.16%]
  • ✔️001_tpch_18: 22.8ms -> 22.6ms [-3.11%, +1.32%]
  • ✔️001_tpch_19: 67.8ms -> 67.7ms [-1.14%, +0.86%]
  • 🚀001_tpch_20: 54.2ms -> 51.4ms [-6%, -4.38%]
  • 🚀001_tpch_21: 87.1ms -> 80.1ms [-9.28%, -6.69%]
  • 🚀001_tpch_22: 70.3ms -> 68.6ms [-3.54%, -1.38%]
  • ❗🐌010_tpch_01: 79.1ms -> 81.8ms [+0.26%, +6.54%]
  • 🚀010_tpch_02: 74.9ms -> 70.9ms [-7.21%, -3.53%]
  • ✔️010_tpch_03: 60ms -> 59.6ms [-2.71%, +1.37%]
  • ✔️010_tpch_04: 42.6ms -> 43.3ms [-0.74%, +3.96%]
  • ✔️010_tpch_05: 92.4ms -> 93.1ms [-2.33%, +3.78%]
  • ✔️010_tpch_06: 32.8ms -> 33.4ms [-8.07%, +11.54%]
  • 🚀010_tpch_07: 113ms -> 108ms [-7.89%, -2.14%]
  • 🚀010_tpch_08: 134ms -> 130ms [-5.1%, -0.78%]
  • ❗🐌010_tpch_09: 115ms -> 117ms [+0.43%, +2.58%]
  • ✔️010_tpch_10: 75.4ms -> 74.7ms [-4.85%, +2.85%]
  • ✔️010_tpch_11: 39.4ms -> 38.6ms [-6.53%, +2.09%]
  • ❗🐌010_tpch_12: 56.2ms -> 57.4ms [+0.35%, +3.87%]
  • ✔️010_tpch_13: 55.2ms -> 53.4ms [-10.81%, +4.31%]
  • ❗🐌010_tpch_14: 37.1ms -> 38.8ms [+0.75%, +8.4%]
  • ✔️010_tpch_15: 55.5ms -> 55.3ms [-6.25%, +5.28%]
  • 🚀010_tpch_16: 46.3ms -> 43.8ms [-8.22%, -2.3%]
  • ✔️010_tpch_17: 54.9ms -> 56.7ms [-1.51%, +8.27%]
  • ✔️010_tpch_18: 54.6ms -> 55.3ms [-5.16%, +7.67%]
  • ✔️010_tpch_19: 117ms -> 117ms [-0.84%, +2.17%]
  • 🚀010_tpch_20: 68.4ms -> 65.7ms [-5.78%, -2.2%]
  • 🚀010_tpch_21: 280ms -> 239ms [-17.14%, -12.09%]
  • ✔️010_tpch_22: 77.9ms -> 77.6ms [-2.36%, +1.42%]
  • ❗🐌100_tpch_01: 284ms -> 323ms [+4.5%, +22.56%]
  • ✔️100_tpch_02: 125ms -> 127ms [-6.94%, +9.92%]
  • ✔️100_tpch_03: 178ms -> 184ms [-1.08%, +7.7%]
  • ✔️100_tpch_04: 141ms -> 148ms [-6.35%, +16.33%]
  • ✔️100_tpch_05: 249ms -> 279ms [-1.27%, +26.11%]
  • ✔️100_tpch_06: 93.2ms -> 108ms [-3.14%, +35.57%]
  • ✔️100_tpch_07: 239ms -> 237ms [-4.2%, +2.91%]
  • ✔️100_tpch_08: 265ms -> 277ms [-6.15%, +15.45%]
  • ✔️100_tpch_09: 327ms -> 351ms [-11.56%, +25.73%]
  • ✔️100_tpch_10: 208ms -> 220ms [-0.47%, +12.29%]
  • ✔️100_tpch_11: 89.8ms -> 89ms [-18.48%, +16.6%]
  • ✔️100_tpch_12: 191ms -> 189ms [-12.95%, +11.05%]
  • ✔️100_tpch_13: 360ms -> 328ms [-18.74%, +0.97%]
  • ✔️100_tpch_14: 116ms -> 121ms [-14.48%, +22.2%]
  • ✔️100_tpch_15: 205ms -> 217ms [-2.35%, +14.12%]
  • ✔️100_tpch_16: 130ms -> 126ms [-7.88%, +1.02%]
  • ❗🐌100_tpch_17: 162ms -> 181ms [+5.14%, +19.14%]
  • ✔️100_tpch_18: 216ms -> 216ms [-13.06%, +13.24%]
  • ✔️100_tpch_19: 289ms -> 286ms [-11.24%, +9.32%]
  • ✔️100_tpch_20: 174ms -> 180ms [-5.61%, +12.43%]
  • 🚀100_tpch_21: 1.52s -> 1.32s [-18.41%, -8.12%]
  • ✔️100_tpch_22: 174ms -> 177ms [-7.1%, +11.18%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr enabled auto-merge (squash) January 24, 2025 17:35
@krlmlr
Copy link
Member

krlmlr commented Jan 24, 2025

Thanks!

@krlmlr krlmlr merged commit f99d3b7 into tidyverse:main Jan 24, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve manual page of flights_df()
2 participants