Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid forwarding is.na() to is.nan() to support non-numeric data #482

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 22, 2025

No description provided.

@krlmlr krlmlr enabled auto-merge (squash) January 22, 2025 15:55
@krlmlr krlmlr marked this pull request as draft January 22, 2025 15:55
auto-merge was automatically disabled January 22, 2025 15:55

Pull request was converted to draft

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8faf6c8 is merged into main:

  • ✔️001_tpch_01: 24.1ms -> 24.5ms [-2.34%, +5.71%]
  • ✔️001_tpch_02: 69.9ms -> 70.3ms [-0.67%, +1.89%]
  • ✔️001_tpch_03: 40.9ms -> 40.5ms [-2.44%, +0.47%]
  • ✔️001_tpch_04: 22.7ms -> 22.9ms [-0.27%, +1.97%]
  • ✔️001_tpch_05: 58.6ms -> 58.9ms [-0.64%, +1.4%]
  • ✔️001_tpch_06: 14.4ms -> 14.6ms [-0.78%, +3.92%]
  • ✔️001_tpch_07: 77.2ms -> 77ms [-2.14%, +1.5%]
  • ✔️001_tpch_08: 101ms -> 100ms [-1.04%, +0.58%]
  • ✔️001_tpch_09: 76.3ms -> 76ms [-1.52%, +0.89%]
  • ✔️001_tpch_10: 50.8ms -> 50.8ms [-1.7%, +1.6%]
  • ✔️001_tpch_11: 33.6ms -> 33.7ms [-1.28%, +1.75%]
  • ✔️001_tpch_12: 28.8ms -> 29ms [-1.11%, +1.92%]
  • ✔️001_tpch_13: 28.2ms -> 28.7ms [-1.66%, +4.97%]
  • ✔️001_tpch_14: 22ms -> 22.2ms [-1.47%, +2.81%]
  • ✔️001_tpch_15: 35.4ms -> 35.1ms [-3.82%, +2.09%]
  • ✔️001_tpch_16: 43.6ms -> 44.2ms [-0.13%, +2.95%]
  • ✔️001_tpch_17: 28.4ms -> 28.5ms [-1.43%, +1.78%]
  • ✔️001_tpch_18: 24.4ms -> 24.2ms [-3.4%, +1.2%]
  • ✔️001_tpch_19: 72ms -> 72.5ms [-1.07%, +2.43%]
  • ✔️001_tpch_20: 58ms -> 57ms [-3.87%, +0.67%]
  • ✔️001_tpch_21: 87.3ms -> 86.1ms [-2.96%, +0.11%]
  • ✔️001_tpch_22: 75.1ms -> 75.1ms [-1.91%, +1.72%]
  • ✔️010_tpch_01: 83.5ms -> 80.5ms [-9.37%, +2.09%]
  • ✔️010_tpch_02: 71.1ms -> 71.7ms [-0.77%, +2.57%]
  • ✔️010_tpch_03: 59.9ms -> 60ms [-0.85%, +1.23%]
  • ✔️010_tpch_04: 43.6ms -> 43.8ms [-1.92%, +3.05%]
  • ✔️010_tpch_05: 93.2ms -> 92.8ms [-3.03%, +2.07%]
  • ✔️010_tpch_06: 34.1ms -> 34.7ms [-6.87%, +10.24%]
  • ✔️010_tpch_07: 112ms -> 111ms [-2.46%, +1.53%]
  • ✔️010_tpch_08: 134ms -> 132ms [-6.21%, +3.78%]
  • ✔️010_tpch_09: 118ms -> 119ms [-0.99%, +2.86%]
  • ✔️010_tpch_10: 75.7ms -> 76.5ms [-1.23%, +3.49%]
  • ✔️010_tpch_11: 39.8ms -> 40.4ms [-2.26%, +5.13%]
  • ✔️010_tpch_12: 58.3ms -> 59.1ms [-1.25%, +3.69%]
  • 🚀010_tpch_13: 54.1ms -> 52.2ms [-6.32%, -0.55%]
  • ✔️010_tpch_14: 38.3ms -> 38.7ms [-0.23%, +2.14%]
  • ✔️010_tpch_15: 54ms -> 56.7ms [-3.27%, +13.13%]
  • ✔️010_tpch_16: 46ms -> 46ms [-3.25%, +3.41%]
  • ✔️010_tpch_17: 55.9ms -> 55.7ms [-4.58%, +3.95%]
  • ✔️010_tpch_18: 55.2ms -> 52.1ms [-13.9%, +2.69%]
  • ✔️010_tpch_19: 117ms -> 116ms [-1.34%, +0.17%]
  • ✔️010_tpch_20: 67ms -> 68.8ms [-0.82%, +6.2%]
  • ✔️010_tpch_21: 245ms -> 246ms [-2.47%, +2.99%]
  • ✔️010_tpch_22: 78.2ms -> 78.8ms [-0.97%, +2.66%]
  • ✔️100_tpch_01: 336ms -> 335ms [-13.73%, +13.03%]
  • ✔️100_tpch_02: 128ms -> 129ms [-3.19%, +5.27%]
  • ✔️100_tpch_03: 183ms -> 184ms [-5.97%, +6.37%]
  • ❗🐌100_tpch_04: 149ms -> 162ms [+1.88%, +14.61%]
  • ✔️100_tpch_05: 263ms -> 262ms [-8.84%, +8.16%]
  • ✔️100_tpch_06: 102ms -> 107ms [-10.54%, +19.93%]
  • ✔️100_tpch_07: 246ms -> 245ms [-6.54%, +5.12%]
  • ✔️100_tpch_08: 262ms -> 256ms [-11.67%, +7.75%]
  • ✔️100_tpch_09: 349ms -> 352ms [-9.19%, +11.03%]
  • ✔️100_tpch_10: 214ms -> 216ms [-14.24%, +16.09%]
  • ✔️100_tpch_11: 86.6ms -> 90.9ms [-16.41%, +26.32%]
  • ✔️100_tpch_12: 196ms -> 206ms [-2.3%, +13.11%]
  • ✔️100_tpch_13: 363ms -> 338ms [-18.34%, +4.59%]
  • ✔️100_tpch_14: 123ms -> 122ms [-19.7%, +18.03%]
  • ✔️100_tpch_15: 217ms -> 211ms [-16.35%, +10.8%]
  • ✔️100_tpch_16: 133ms -> 133ms [-14.53%, +13.9%]
  • ✔️100_tpch_17: 182ms -> 178ms [-12.22%, +7.49%]
  • ✔️100_tpch_18: 194ms -> 192ms [-4.78%, +2.97%]
  • ✔️100_tpch_19: 309ms -> 277ms [-22.51%, +1.53%]
  • ✔️100_tpch_20: 182ms -> 186ms [-3.11%, +7.37%]
  • ✔️100_tpch_21: 1.35s -> 1.35s [-8.69%, +8.01%]
  • ✔️100_tpch_22: 173ms -> 177ms [-6.84%, +11.41%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant